linux-kernel - Re: [RFC PATCH 09/14] sunrpc: add basic support for workqueue-based services

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141208204709.GA19437@fieldses.org>
Date:	Mon, 8 Dec 2014 15:47:09 -0500
From:	"J. Bruce Fields" <bfields@...ldses.org>
To:	Jeff Layton <jlayton@...marydata.com>
Cc:	linux-nfs@...r.kernel.org, linux-kernel@...r.kernel.org,
	Tejun Heo <tj@...nel.org>, Al Viro <viro@...iv.linux.org.uk>
Subject: Re: [RFC PATCH 09/14] sunrpc: add basic support for workqueue-based
 services

On Tue, Dec 02, 2014 at 01:24:18PM -0500, Jeff Layton wrote:
> diff --git a/net/sunrpc/Kconfig b/net/sunrpc/Kconfig
> index fb78117b896c..08e01949bdc5 100644
> --- a/net/sunrpc/Kconfig
> +++ b/net/sunrpc/Kconfig
> @@ -71,3 +71,13 @@ config SUNRPC_XPRT_RDMA_SERVER
>  	  choose M here: the module will be called svcrdma.
>  
>  	  If unsure, say N.
> +
> +config SUNRPC_SVC_WORKQUEUE
> +	bool "Support for workqueue-based SUNRPC services"
> +	depends on SUNRPC
> +	default	n
> +	help
> +	  Traditional SUNRPC services have required a dedicated thread
> +	  to handle incoming requests. This option enables support for
> +	  queueing incoming reqests to a workqueue instead, eliminating
> +	  the need for a dedicated thread pool.

Minor point, but: If people don't want this, they can turn it off at
runtime.  It's annoying to test all the possible combination of build
options, and this doesn't seem likely to let people e.g. build a
significantly smaller kernel, so I wouldn't bother.

--b.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/