linux-kernel - Re: [PATCHv2 1/3] sunxi:dts-bindings:input:ps2 bindings for A10/A20 ps2.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141208221509.GM8739@lukather>
Date:	Mon, 8 Dec 2014 23:15:09 +0100
From:	Maxime Ripard <maxime.ripard@...e-electrons.com>
To:	vishnupatekar <vishnupatekar0510@...il.com>
Cc:	linux-sunxi@...glegroups.com, dmitry.torokhov@...il.com,
	linux@....linux.org.uk, leafy.myeh@...bietech.com,
	robh+dt@...nel.org, pawel.moll@....com, mark.rutland@....com,
	ijc+devicetree@...lion.org.uk, galak@...eaurora.org,
	devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org, linux-input@...r.kernel.org
Subject: Re: [PATCHv2 1/3] sunxi:dts-bindings:input:ps2 bindings for A10/A20
 ps2.

Hi,

On Sun, Dec 07, 2014 at 04:45:17AM +0530, vishnupatekar wrote:
> A10 and A20 have same PS2 addresses, clocks, interrupts.
> added compatible as allwinner,sun4i-a10-ps2.
> 
> Signed-off-by: vishnupatekar <VishnuPatekar0510@...il.com>

You should have your real name here.

> ---
>  .../bindings/input/allwinner,sunxi-ps2.txt         |   23 ++++++++++++++++++++
>  1 file changed, 23 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/input/allwinner,sunxi-ps2.txt
> 
> diff --git a/Documentation/devicetree/bindings/input/allwinner,sunxi-ps2.txt b/Documentation/devicetree/bindings/input/allwinner,sunxi-ps2.txt
> new file mode 100644
> index 0000000..3a8919a
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/input/allwinner,sunxi-ps2.txt
> @@ -0,0 +1,23 @@
> +* Device tree bindings for Allwinner A10, A20 PS2 host controller

> +A20 PS2 is dual role controller(PS2 host and PS2 device). These
> +bindings are for PS2 host controller. IBM compliant IBM PS2 and
> AT-compatible keyboard and mouse can be connected.

This should be wrapped to 80 chars.

> +Required properties:
> +
> + - reg             : Offset and length of the register set for the device.
> + - compatible      : Should one of the following:
> +                     - "allwinner,sun7i-a20-ps2"
> +                     - "allwinner,sun4i-a10-ps2"
> + - interrupts      : The interrupt line connected to the PS2.
> + - clocks          : The gate clk connected to the PS2.
> +
> +
> +Example:
> +	ps20: ps2@...1c2a000 {
> +		compatible = "allwinner,sun7i-a20-ps2";
> +		reg = <0x01c2a000 0x400>;
> +		interrupts = <0 62 4>;
> +		clocks = <&apb1_gates 6>;
> +		status = "disabled";
> +	};
> -- 
> 1.7.9.5
> 

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)