linux-kernel - Re: [PATCH 0/20] fix misspelling of current function in string

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.02.1412080738210.2100@localhost6.localdomain6>
Date:	Mon, 8 Dec 2014 07:43:16 +0100 (CET)
From:	Julia Lawall <julia.lawall@...6.fr>
To:	Julian Calaby <julian.calaby@...il.com>
cc:	Julia Lawall <Julia.Lawall@...6.fr>,
	linux-wireless <linux-wireless@...r.kernel.org>,
	kernel-janitors@...r.kernel.org, linux@...musvillemoes.dk,
	Joe Perches <joe@...ches.com>,
	"devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
	linux-scsi <linux-scsi@...r.kernel.org>,
	dri-devel@...ts.freedesktop.org, intel-gfx@...ts.freedesktop.org,
	linux-mtd@...ts.infradead.org, linux-samsung-soc@...r.kernel.org,
	"Mailing List, Arm" <linux-arm-kernel@...ts.infradead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	linux-pci@...r.kernel.org, netdev <netdev@...r.kernel.org>,
	linux-usb@...r.kernel.org
Subject: Re: [PATCH 0/20] fix misspelling of current function in string

On Mon, 8 Dec 2014, Julian Calaby wrote:

> Hi Julia,
> 
> On Mon, Dec 8, 2014 at 6:20 AM, Julia Lawall <Julia.Lawall@...6.fr> wrote:
> > These patches replace what appears to be a reference to the name of the
> > current function but is misspelled in some way by either the name of the
> > function itself, or by %s and then __func__ in an argument list.
> 
> Would there be any value in doing this for _all_ cases where the
> function name is written in a format string?

Probably.  But there are a lot of them.  Even for the misspellings, I have 
only don about 1/3 of the cases.

On the other hand, the misspelling have to be checked carefully, because a 
misspelling of one thing could be the correct spelling of the thing thst 
was actually intended.

Joe, however, points out that a lot of these prints are just for function 
tracing, and could be removed.  I worked on another semantic patch that 
tries to do that.  It might be better to remove those prints completely, 
rather than sending one patch to transform them and then one patch to 
remove them after that.  That is why for this series I did only the ones 
where there was actually a problem.

julia
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/