linux-kernel - Re: [PATCH] USB: serial: add nt124 usb to serial driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAFSKS=O0amUJTHf2Pk_orfep9AF4mAqU4-gxzi5jqUBD7vThMg@mail.gmail.com>
Date:	Mon, 8 Dec 2014 18:51:20 -0600
From:	George McCollister <george.mccollister@...il.com>
To:	Jeremiah Mahler <jmmahler@...il.com>,
	George McCollister <george.mccollister@...il.com>,
	linux-usb@...r.kernel.org, open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] USB: serial: add nt124 usb to serial driver

Thanks for the review.

I didn't update the MAINTAINERS file because I looked in it and didn't
see any other individual usb/serial drivers listed with maintainers.

-George

On Mon, Dec 8, 2014 at 6:29 PM, Jeremiah Mahler <jmmahler@...il.com> wrote:
> George,
>
> On Mon, Dec 08, 2014 at 05:24:17PM -0600, George McCollister wrote:
>> This driver is for the NovaTech 124 4x serial expansion board for the
>> NovaTech OrionLXm.
>>
>> Firmware source code can be found here:
>> https://github.com/novatechweb/nt124
>>
>> Signed-off-by: George McCollister <george.mccollister@...il.com>
>> ---
>>  drivers/usb/serial/Kconfig  |   9 +
>>  drivers/usb/serial/Makefile |   1 +
>>  drivers/usb/serial/nt124.c  | 429 ++++++++++++++++++++++++++++++++++++++++++++
>>  3 files changed, 439 insertions(+)
>>  create mode 100644 drivers/usb/serial/nt124.c
>>
>> diff --git a/drivers/usb/serial/Kconfig b/drivers/usb/serial/Kconfig
> [...]
>
> It applies to next without any errors, there are no checkpatch issues
> other than recommending updating the MAINTAINERS file, and I can't find
> any other obvious problems.  Looks good to me.
>
> Reviewed-by: Jeremiah Mahler <jmmahler@...il.com>
>
> --
> - Jeremiah Mahler
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/