linux-kernel - Re: [PATCH v2] CPU hotplug: active_writer not woken up in some cases

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 9 Dec 2014 11:21:08 +0100
From:	Heiko Carstens <heiko.carstens@...ibm.com>
To:	David Hildenbrand <dahi@...ux.vnet.ibm.com>
Cc:	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>,
	linux-kernel@...r.kernel.org, borntraeger@...ibm.com,
	rafael.j.wysocki@...el.com, peterz@...radead.org, oleg@...hat.com,
	bp@...e.de, jkosina@...e.cz
Subject: Re: [PATCH v2] CPU hotplug: active_writer not woken up in some cases
 - deadlock

On Tue, Dec 09, 2014 at 11:11:01AM +0100, David Hildenbrand wrote:
> > > Therefore we have to move the condition check inside the 
> > >   __set_current_state(TASK_UNINTERRUPTIBLE) -> schedule();
> > > section to not miss any wake ups when the condition is satisfied.
> > > 
> > > So wake_up_process() will either see TASK_RUNNING and do nothing or see
> > > TASK_UNINTERRUPTIBLE and set it to TASK_RUNNING, so schedule() will in
> > > fact be woken up again.
> > 
> > Or the third alternative would be that 'active_writer' which was running
> > on CPU2 already terminated and wake_up_process() has a non-NULL pointer to
> > task_struct which is already dead.
> > Or is there anything that prevents this use-after-free race?
> 
> Hmmm ... I think that is also a valid scenario.
> That would mean we need soemthing like this:
> 
>  void put_online_cpus(void)
>  {
> + struct task_struct *awr;
> +
>         if (cpu_hotplug.active_writer == current)
>                 return;
>         if (!mutex_trylock(&cpu_hotplug.lock)) {
> +         awr = ACCESS_ONCE(cpu_hotplug.active_writer);
> +         if (unlikely(awr))
> +                 get_task_struct(awr);

How would this solve the problem?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/