linux-kernel - Re: [PATCH 2/3] kconfig: remove undocumented type definition alias 'boolean'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5486E1BD.4040809@redhat.com>
Date:	Tue, 09 Dec 2014 12:49:17 +0100
From:	Daniel Borkmann <dborkman@...hat.com>
To:	Paul Bolle <pebolle@...cali.nl>
CC:	Christoph Jaeger <cj@...ux.com>, yann.morin.1998@...e.fr,
	linux-kbuild@...r.kernel.org, linux-kernel@...r.kernel.org,
	akpm@...ux-foundation.org
Subject: Re: [PATCH 2/3] kconfig: remove undocumented type definition alias
 'boolean'

On 12/08/2014 10:15 PM, Paul Bolle wrote:
> On Mon, 2014-12-08 at 21:36 +0100, Paul Bolle wrote:
>> On Mon, 2014-12-08 at 20:41 +0100, Paul Bolle wrote:
>>> Well, it seems the treewide "boolean" cleanup should be done first.
>>> Removing support for "boolean" could than be a second, separate step.
>>> Just to ease review.
>>
>> This appears to have no effect on the .config files I generated for the
>> defconfig files in next-20141208. (After porting the patch and changing
>> those last booleans to bool, that is.) So that's good.
>>
>> If you'd resend as two patches on top of linux-next, I might add an
>> Acked-by: or a Tested-by:.
>
> My last mail on this series. To make sure the tree stays buildable that
> second patch to drop support for 'boolean' should only be applied a
> release or two after the cleanup patch has been applied. Otherwise we're
> bound to run into fun build errors in linux-next, and even mainline, for
> quite a few commits, aren't we? One tree still using boolean is all it
> takes...

Sounds like a good plan, thanks a lot for looking into it, Paul!

Meanwhile, also checkpatch.pl could emit a deprecate warning in case
a patch carries Kconfig code with 'boolean' in it, but I leave that
up to Christoph to decide. ;)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/