linux-kernel - Re: [PATCH] staging: ion: ion_cma_heap: remove ion_cma_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1418088558.15957.5.camel@perches.com>
Date:	Mon, 08 Dec 2014 17:29:18 -0800
From:	Joe Perches <joe@...ches.com>
To:	Zeng Tao <prime.zeng@...wei.com>
Cc:	gregkh@...uxfoundation.org, john.stultz@...aro.org,
	ccross@...roid.com, rebecca@...roid.com,
	fabio.estevam@...escale.com, tranmanphong@...il.com,
	benjamin.gaignard@...aro.org, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: ion: ion_cma_heap: remove ion_cma_get_sgtable

On Tue, 2014-12-09 at 09:19 +0800, Zeng Tao wrote:
> Remove the temporary code ion_cma_get_sgtable,
> use dma_common_get_sgtable instead
[]
> diff --git a/drivers/staging/android/ion/ion_cma_heap.c b/drivers/staging/android/ion/ion_cma_heap.c
[]
> @@ -91,7 +73,7 @@ static int ion_cma_allocate(struct ion_heap *heap, struct ion_buffer *buffer,
>  	if (!info->table)
>  		goto free_mem;
>  
> -	if (ion_cma_get_sgtable
> +	if (dma_common_get_sgtable
>  	    (dev, info->table, info->cpu_addr, info->handle, len))
>  		goto free_table;
>  	/* keep this for memory release */

somewhat unrelated trivia:

It'd conform a bit more to kernel style to
write this with at least one argument on the
same line as the function like:

	if (dma_common_get_sgtable(dev, info->table, info->cpu_addr,
				   info->handle, len))
		goto  free_table;

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/