linux-kernel - Re: [PATCH] PCI: Clear bridge MEM_64 flag if one child does not support it

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAE9FiQWrMs4b5HmbiJTmq=3g_Pv1_Zp1c5=P=uXTgLD6Txs-Bw@mail.gmail.com>
Date:	Tue, 9 Dec 2014 11:49:34 -0800
From:	Yinghai Lu <yinghai@...nel.org>
To:	Wei Yang <weiyang@...ux.vnet.ibm.com>
Cc:	Marek Kordík <kordikmarek@...il.com>,
	Alexey Voronkov <zermond@...il.com>,
	Gavin Shan <gwshan@...ux.vnet.ibm.com>,
	Benjamin Herrenschmidt <benh@...nel.crashing.org>,
	Bjorn Helgaas <bhelgaas@...gle.com>,
	"linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] PCI: Clear bridge MEM_64 flag if one child does not
 support it

On Mon, Dec 8, 2014 at 11:56 PM, Wei Yang <weiyang@...ux.vnet.ibm.com> wrote:

> Two comments to this patch:
> 1. realloc_head is not necessary here

why ?

want to align that with pbus_size_mem.

> 2. In case we have two MEM BAR under a bus, one is MEM64|PREF and one is PREF,
> after this patch, the MEM64 flag will be cleared, right? If so, this may fall
> back to the same situation in bug 74151.

Yes.

Thanks

Yinghai
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/