linux-kernel - Re: [PATCH v2 0/6] net-PPP: Deletion of a few unnecessary checks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20141209.145447.2234157264287438778.davem@davemloft.net>
Date:	Tue, 09 Dec 2014 14:54:47 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	elfring@...rs.sourceforge.net
Cc:	sergei.shtylyov@...entembedded.com, paulus@...ba.org,
	linux-ppp@...r.kernel.org, netdev@...r.kernel.org,
	eric.dumazet@...il.com, linux-kernel@...r.kernel.org,
	kernel-janitors@...r.kernel.org, julia.lawall@...6.fr
Subject: Re: [PATCH v2 0/6] net-PPP: Deletion of a few unnecessary checks

From: SF Markus Elfring <elfring@...rs.sourceforge.net>
Date: Thu, 04 Dec 2014 23:03:30 +0100

> From: Markus Elfring <elfring@...rs.sourceforge.net>
> Date: Thu, 4 Dec 2014 22:50:28 +0100
> 
> Further update suggestions were taken into account before and after a patch
> was applied from static source code analysis.

Generally speaking, it is advisable to not leave error pointers in data
structures, even if they are about to be free'd up in an error path
anyways.

Therefore I do not like some of the patches in this series.

Sorry.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/