linux-kernel - Re: [PATCH 1/3] i8k: cosmetic: distinguish between fan speed and fan rpm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141209202304.GB22176@roeck-us.net>
Date:	Tue, 9 Dec 2014 12:23:04 -0800
From:	Guenter Roeck <linux@...ck-us.net>
To:	Pali Rohár <pali.rohar@...il.com>
Cc:	Arnd Bergmann <arnd@...db.de>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Jean Delvare <jdelvare@...e.de>,
	Gabriele Mazzotta <gabriele.mzt@...il.com>,
	Steven Honeyman <stevenhoneyman@...il.com>,
	Jochen Eisinger <jochen@...guin-breeder.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] i8k: cosmetic: distinguish between fan speed and fan
 rpm

On Tue, Dec 09, 2014 at 09:06:59PM +0100, Pali Rohár wrote:
> Driver mix speed and rpm. Fan speed is value (0, 1, 2) which is used for
> configuring fan. This patch change comments, function names and other
> definitions so code should be unambiguous now.
> 
> Signed-off-by: Pali Rohár <pali.rohar@...il.com>
> ---
> This patch is cosmetic and does not bring any change to code.

For me "speed" and "rpm" are synonyms. So you are not really clarifying
anything. If anything, you make the code even more confusing.

Guenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/