linux-kernel - Re: [PATCH] staging: lustre: Fix the warning messages about casting without _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141210070957.GN22149@ZenIV.linux.org.uk>
Date:	Wed, 10 Dec 2014 07:09:59 +0000
From:	Al Viro <viro@...IV.linux.org.uk>
To:	Shalin Mehta <shalinmehta85@...il.com>
Cc:	andreas.dilger@...el.com, gregkh@...uxfoundation.org,
	bergwolf@...il.com, gdonald@...il.com, peterz@...radead.org,
	tranmanphong@...il.com, massa.nomura@...il.com,
	HPDD-discuss@...1.01.org, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org, majordomo@...r.kernel.org
Subject: Re: [PATCH] staging: lustre: Fix the warning messages about casting
 without __user macro

On Tue, Dec 09, 2014 at 10:56:12PM -0800, Shalin Mehta wrote:
> From: Shalin Mehta <shalinmehta85@...il.com>
> 
> This issue is showed up while compiling with sparse. The iov_base in struct iovec struct explicitly declares that the assigned value should be user space pointer with __user macro. Where as here, the __user macro isn't used while casting.

... and pointers are not user space ones at all.  Which is to say, quit
messing with casts; it's not struct iovec.  Proper fix is to replace
it here (and in almost all places throughout drivers/staging/lustre) with
struct kvec.  And yes, such a patch had been sent.  Still not applied,
AFAICS...
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/