| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Tue, 9 Dec 2014 16:41:40 -0800 From: Doug Anderson <dianders@...omium.org> To: Chris Zhong <zyw@...k-chips.com> Cc: Heiko Stübner <heiko@...ech.de>, "broonie@...nel.org" <broonie@...nel.org>, "open list:ARM/Rockchip SoC..." <linux-rockchip@...ts.infradead.org>, Liam Girdwood <lgirdwood@...il.com>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org> Subject: Re: [PATCH 1/2] regulator: rk808: add dvs support Chris, On Tue, Dec 9, 2014 at 5:51 AM, Chris Zhong <zyw@...k-chips.com> wrote: > + /* dvsok pin would be pull down when dvs1/2 pin changed, and > + * it would be pull up once the voltage regulate complete. > + * No need to wait dvsok signal when voltage falling. > + */ A tiny nit that I think standard multiline commenting style should make the above: + /* + * dvsok pin would be pull down when dvs1/2 pin changed, and + * it would be pull up once the voltage regulate complete. + * No need to wait dvsok signal when voltage falling. + */ ...but I'll leave it up to broonie@ if he cares... Given that I've privately reviewed an earlier version of this before you sent it up, it's not surprising that I have no other comments, so: Reviewed-by: Doug Anderson <dianders@...omium.org> :) -Doug -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists