linux-kernel - Re: [PATCH v13 09/12] input: cyapa: add gen5 trackpad device firmware update function support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141210085455.GA7174@hudson.localdomain>
Date:	Wed, 10 Dec 2014 00:54:55 -0800
From:	Jeremiah Mahler <jmmahler@...il.com>
To:	Dudley Du <dudley.dulixin@...il.com>
Cc:	linux-kernel@...r.kernel.org, linux-input@...r.kernel.org
Subject: Re: [PATCH v13 09/12] input: cyapa: add gen5 trackpad device
 firmware update function support

Dudley,

On Tue, Dec 09, 2014 at 07:33:03PM -0800, Jeremiah Mahler wrote:
> Dudley,
> 
> On Tue, Dec 09, 2014 at 05:11:41PM +0800, Dudley Du wrote:
> > Add firmware image update function supported for gen5 trackpad device,
> > it can be used through sysfs update_fw interface.
> > TEST=test on Chromebooks.
> > 
> > Signed-off-by: Dudley Du <dudley.dulixin@...il.com>
> > ---
> >  drivers/input/mouse/Kconfig      |   2 +-
> >  drivers/input/mouse/cyapa_gen5.c | 290 +++++++++++++++++++++++++++++++++++++++
> >  2 files changed, 291 insertions(+), 1 deletion(-)
> > 
> > diff --git a/drivers/input/mouse/Kconfig b/drivers/input/mouse/Kconfig
> > index d8b46b0..63e8b40 100644
> > --- a/drivers/input/mouse/Kconfig
> > +++ b/drivers/input/mouse/Kconfig
> > @@ -205,7 +205,7 @@ config MOUSE_BCM5974
> >  
> >  config MOUSE_CYAPA
> >  	tristate "Cypress APA I2C Trackpad support"
> > -	depends on I2C
> > +	depends on I2C && CRC_ITU_T
If this line is instead changed to:

+  depends on I2C
+  select CRC_ITU_T

It will upgrade correctly during make oldconfig without removing
MOUSE_CYAPA.

And it looks like several other Kconfig files do it this way already.

  linux-next$ grep -r CRC_ITU_T $(find ./ -name Kconfig)

> >  	help
> >  	  This driver adds support for Cypress All Points Addressable (APA)
> >  	  I2C Trackpads, including the ones used in 2012 Samsung Chromebooks.
> > diff --git a/drivers/input/mouse/cyapa_gen5.c b/drivers/input/mouse/cyapa_gen5.c
> 
> My initial config had MOUSE_CYAPA=m and CRC_ITU_T=n.
> I did a 'make oldconfig', no questions were asked, but it removed
> MOUSE_CYAPA since CRC_ITU_T wasn't enabled.  Since the cyapa modules
> were removed the touchpad no longer works.  Not a very good upgrade path :-(
> To fix this I have to manually enable MOUSE_CYAPA and CRC_ITU_T to get
> it working again.
> 
> [...]
> 
> -- 
> - Jeremiah Mahler

-- 
- Jeremiah Mahler
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/