linux-kernel - [PATCH v2] irqchip: mediatek: Use IS_ERR() instead of NULL pointer check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1418205302-22531-1-git-send-email-yingjoe.chen@mediatek.com>
Date:	Wed, 10 Dec 2014 17:55:02 +0800
From:	Yingjoe Chen <yingjoe.chen@...iatek.com>
To:	Thomas Gleixner <tglx@...utronix.de>,
	Beniamino Galvani <b.galvani@...il.com>,
	Jason Cooper <jason@...edaemon.net>
CC:	Marc Zyngier <marc.zyngier@....com>, <srv_heupstream@...iatek.com>,
	<hc.yen@...iatek.com>, <yh.chen@...iatek.com>,
	<linux-kernel@...r.kernel.org>,
	Matthias Brugger <matthias.bgg@...il.com>,
	<nathan.chung@...iatek.com>, Sascha Hauer <kernel@...gutronix.de>,
	<eddie.huang@...iatek.com>, <yingjoe.chen@...il.com>,
	<linux-arm-kernel@...ts.infradead.org>,
	Yingjoe Chen <yingjoe.chen@...iatek.com>
Subject: [PATCH v2] irqchip: mediatek: Use IS_ERR() instead of NULL pointer check

Beniamino reported a kernel oops caused by an invalid DT file for the
mediatek interrupt polarity extension.

The reason is that the interrupt polarity support for mediatek chips
merely checks for NULL pointer instead of a casted error return
value in mtk_sysirq_of_init() so any other casted error value passes
the NULL pointer check and causes a kernel panic when dereferenced.

Use IS_ERR() and return the error value via PTR_ERR().

Reported-and-tested-by: Beniamino Galvani <b.galvani@...il.com>
Signed-off-by: Yingjoe Chen <yingjoe.chen@...iatek.com>
---
 drivers/irqchip/irq-mtk-sysirq.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/irqchip/irq-mtk-sysirq.c b/drivers/irqchip/irq-mtk-sysirq.c
index 7e342df..0b0d2c0 100644
--- a/drivers/irqchip/irq-mtk-sysirq.c
+++ b/drivers/irqchip/irq-mtk-sysirq.c
@@ -137,9 +137,9 @@ static int __init mtk_sysirq_of_init(struct device_node *node,
 		return -ENOMEM;
 
 	chip_data->intpol_base = of_io_request_and_map(node, 0, "intpol");
-	if (!chip_data->intpol_base) {
+	if (IS_ERR(chip_data->intpol_base)) {
 		pr_err("mtk_sysirq: unable to map sysirq register\n");
-		ret = -ENOMEM;
+		ret = PTR_ERR(chip_data->intpol_base);
 		goto out_free;
 	}
 
-- 
1.8.1.1.dirty

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/