linux-kernel - Re: [PATCH] staging: rts5208: Removed the new typedefs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 10 Dec 2014 09:20:03 -0500
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Anjana Sasindran <anjanasasindran123@...il.com>
Cc:	linux-kernel@...r.kernel.org, devel@...verdev.osuosl.org
Subject: Re: [PATCH] staging: rts5208: Removed the new typedefs

On Wed, Dec 10, 2014 at 07:24:16PM +0530, Anjana Sasindran wrote:
> This patch fix the checkpatch.pl warning:
> 
> WARNING: do not add new typedefs
> 
> Signed-off-by: Anjana Sasindran <anjanasasindran123@...il.com>
> ---
>  drivers/staging/rts5208/rtsx_sys.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/rts5208/rtsx_sys.h b/drivers/staging/rts5208/rtsx_sys.h
> index 0b6b4d4..f04d997 100644
> --- a/drivers/staging/rts5208/rtsx_sys.h
> +++ b/drivers/staging/rts5208/rtsx_sys.h
> @@ -28,7 +28,7 @@
>  #include "rtsx_chip.h"
>  #include "rtsx_card.h"
>  
> -typedef dma_addr_t ULONG_PTR;
> +dma_addr_t ULONG_PTR;
>  
>  static inline void rtsx_exclusive_enter_ss(struct rtsx_chip *chip)
>  {

Please learn how the C language works before attempting to contribute to
the Linux kernel.  You obviously didn't even test build this code, which
means you are trying to waste my time, a very rude thing to do to
someone else, don't you think?

*plonk*
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/