linux-kernel - Re: [PATCH 0/2] virtio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141210184238.12725264.cornelia.huck@de.ibm.com>
Date:	Wed, 10 Dec 2014 18:42:38 +0100
From:	Cornelia Huck <cornelia.huck@...ibm.com>
To:	"Michael S. Tsirkin" <mst@...hat.com>
Cc:	linux-kernel@...r.kernel.org,
	Rusty Russell <rusty@...tcorp.com.au>,
	virtualization@...ts.linux-foundation.org
Subject: Re: [PATCH 0/2] virtio_ccw: minor enhancements

On Tue, 9 Dec 2014 20:50:35 +0200
"Michael S. Tsirkin" <mst@...hat.com> wrote:

> On Tue, Dec 09, 2014 at 06:27:53PM +0100, Cornelia Huck wrote:
> > On Tue, 9 Dec 2014 15:53:32 +0200
> > "Michael S. Tsirkin" <mst@...hat.com> wrote:
> > 
> > > Two enhancements for virtio_ccw, on top of latest 1.0 patchset
> > > 
> > > Cornelia Huck (1):
> > >   virtio_ccw: finalize_features error handling
> > > 
> > > Michael S. Tsirkin (1):
> > >   virtio_ccw: future-proof finalize_features
> > > 
> > >  drivers/s390/kvm/virtio_ccw.c | 18 +++++++++++-------
> > >  1 file changed, 11 insertions(+), 7 deletions(-)
> > > 
> > 
> > I tried to run this as a guest kernel with my virtio-1 qemu branch +
> > your revision patch on top and it at least boots :) More testing
> > tomorrow.
> 
> It's best if you pick my tree from git.
> vhost-next branch.
> 

FWIW: Your current vhost-next branch + my qemu with the known bugs
seems to hold up well so far; the endianness swap does not seem to
cause a noticeable performance hit (the problems come from my qemu code
dropping feature bits...)

Take this with a grain of salt as current qemu virtio-1 has known
problems, but I don't think there are major reasons speaking against
inclusion. At least, I don't think there's anything in there we can't
easily fix up later.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/