linux-kernel - RE: [PATCH 2/5] Tools: hv: remove unused bytes_written from kvp_update

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BY2PR0301MB07117433E01C33419CE67B02A0620@BY2PR0301MB0711.namprd03.prod.outlook.com>
Date:	Wed, 10 Dec 2014 18:49:05 +0000
From:	KY Srinivasan <kys@...rosoft.com>
To:	Vitaly Kuznetsov <vkuznets@...hat.com>
CC:	Haiyang Zhang <haiyangz@...rosoft.com>,
	"devel@...uxdriverproject.org" <devel@...uxdriverproject.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Dexuan Cui <decui@...rosoft.com>
Subject: RE: [PATCH 2/5] Tools: hv: remove unused bytes_written from
 kvp_update_file()



> -----Original Message-----
> From: Vitaly Kuznetsov [mailto:vkuznets@...hat.com]
> Sent: Tuesday, December 9, 2014 7:48 AM
> To: KY Srinivasan
> Cc: Haiyang Zhang; devel@...uxdriverproject.org; linux-
> kernel@...r.kernel.org; Dexuan Cui
> Subject: [PATCH 2/5] Tools: hv: remove unused bytes_written from
> kvp_update_file()
> 
> fwrite() does not actually return the number of bytes written and this value
> is being ignored anyway and ferror() is being called to check for an error. As
> we assign to this variable and never use it we get the following compile-time
> warning:
> hv_kvp_daemon.c:149:9: warning: variable ‘bytes_written’ set but not used
> [-Wunused-but-set-variable]
> 
> Remove bytes_written completely.
> 
> Signed-off-by: Vitaly Kuznetsov <vkuznets@...hat.com>
Signed-off-by: K. Y. Srinivasan <kys@...rosoft.com>
> ---
>  tools/hv/hv_kvp_daemon.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/tools/hv/hv_kvp_daemon.c b/tools/hv/hv_kvp_daemon.c index
> 6a6432a..5a274ca 100644
> --- a/tools/hv/hv_kvp_daemon.c
> +++ b/tools/hv/hv_kvp_daemon.c
> @@ -147,7 +147,6 @@ static void kvp_release_lock(int pool)  static void
> kvp_update_file(int pool)  {
>  	FILE *filep;
> -	size_t bytes_written;
> 
>  	/*
>  	 * We are going to write our in-memory registry out to @@ -163,8
> +162,7 @@ static void kvp_update_file(int pool)
>  		exit(EXIT_FAILURE);
>  	}
> 
> -	bytes_written = fwrite(kvp_file_info[pool].records,
> -				sizeof(struct kvp_record),
> +	fwrite(kvp_file_info[pool].records, sizeof(struct kvp_record),
>  				kvp_file_info[pool].num_records, filep);
> 
>  	if (ferror(filep) || fclose(filep)) {
> --
> 1.9.3