linux-kernel - RE: [PATCH 4/5] Tools: hv: address compiler warnings for hv_fcopy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BY2PR0301MB071185A92053C71F55ADDDF4A0620@BY2PR0301MB0711.namprd03.prod.outlook.com>
Date:	Wed, 10 Dec 2014 18:55:13 +0000
From:	KY Srinivasan <kys@...rosoft.com>
To:	Vitaly Kuznetsov <vkuznets@...hat.com>
CC:	Haiyang Zhang <haiyangz@...rosoft.com>,
	"devel@...uxdriverproject.org" <devel@...uxdriverproject.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Dexuan Cui <decui@...rosoft.com>
Subject: RE: [PATCH 4/5] Tools: hv: address compiler warnings for
 hv_fcopy_daemon.c



> -----Original Message-----
> From: Vitaly Kuznetsov [mailto:vkuznets@...hat.com]
> Sent: Tuesday, December 9, 2014 7:48 AM
> To: KY Srinivasan
> Cc: Haiyang Zhang; devel@...uxdriverproject.org; linux-
> kernel@...r.kernel.org; Dexuan Cui
> Subject: [PATCH 4/5] Tools: hv: address compiler warnings for
> hv_fcopy_daemon.c
> 
> This patch addresses two types of compiler warnings:
> ... warning: unused variable ‘fd’ [-Wunused-variable] and ... warning: format
> ‘%s’ expects argument of type ‘char *’, but argument 5 has type ‘__u16 *’ [-
> Wformat=]
> 
> Signed-off-by: Vitaly Kuznetsov <vkuznets@...hat.com>

Signed-off-by: K. Y. Srinivasan <kys@...rosoft.com>
> ---
>  tools/hv/hv_fcopy_daemon.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/hv/hv_fcopy_daemon.c b/tools/hv/hv_fcopy_daemon.c
> index f437d73..1a23872 100644
> --- a/tools/hv/hv_fcopy_daemon.c
> +++ b/tools/hv/hv_fcopy_daemon.c
> @@ -51,7 +51,7 @@ static int hv_start_fcopy(struct hv_start_fcopy *smsg)
> 
>  	p = (char *)smsg->path_name;
>  	snprintf(target_fname, sizeof(target_fname), "%s/%s",
> -		(char *)smsg->path_name, smsg->file_name);
> +		 (char *)smsg->path_name, (char *)smsg->file_name);
> 
>  	syslog(LOG_INFO, "Target file name: %s", target_fname);
>  	/*
> @@ -137,7 +137,7 @@ void print_usage(char *argv[])
> 
>  int main(int argc, char *argv[])
>  {
> -	int fd, fcopy_fd, len;
> +	int fcopy_fd, len;
>  	int error;
>  	int daemonize = 1, long_index = 0, opt;
>  	int version = FCOPY_CURRENT_VERSION;
> --
> 1.9.3