linux-kernel - Re: [PATCH] net/macb: add TX multiqueue support for gem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20141210.151550.855246066396941606.davem@davemloft.net>
Date:	Wed, 10 Dec 2014 15:15:50 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	cyrille.pitchen@...el.com
Cc:	nicolas.ferre@...el.com, linux-arm-kernel@...ts.infradead.org,
	netdev@...r.kernel.org, soren.brinkmann@...inx.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net/macb: add TX multiqueue support for gem

From: Cyrille Pitchen <cyrille.pitchen@...el.com>
Date: Wed, 10 Dec 2014 16:03:51 +0100

> +	netdev_vdbg(bp->dev, "macb_tx_error_task: q = %u, t = %u, h = %u\n",
> +		    queue - bp->queues, queue->tx_tail, queue->tx_head);

This and another change int his patch adds build warnings because
"ptr1 - ptr2" is a ptrdiff_t, which is a long int on some platforms:

drivers/net/ethernet/cadence/macb.c: In function ‘macb_tx_error_task’:
drivers/net/ethernet/cadence/macb.c:504:2: warning: format ‘%u’ expects argument of type ‘unsigned int’, but argument 4 has type ‘long int’ [-Wformat]
drivers/net/ethernet/cadence/macb.c: In function ‘macb_interrupt’:
drivers/net/ethernet/cadence/macb.c:988:3: warning: format ‘%u’ expects argument of type ‘unsigned int’, but argument 4 has type ‘long int’ [-Wformat]