linux-kernel - Re: [PATCH] phy: phy-samsung-usb2: Don't use same name for driver name and global structure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAFp+6iFa+hqQGD7BuAMOkb7i-kbJaV-OBuBf5RWNNadiuZORYg@mail.gmail.com>
Date:	Thu, 11 Dec 2014 16:30:54 +0530
From:	Vivek Gautam <gautamvivek1987@...il.com>
To:	Kamil Debski <k.debski@...sung.com>
Cc:	Kishon Vijay Abraham I <kishon@...com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Linux USB Mailing List <linux-usb@...r.kernel.org>,
	Vivek Gautam <gautam.vivek@...sung.com>
Subject: Re: [PATCH] phy: phy-samsung-usb2: Don't use same name for driver
 name and global structure

On Thu, Dec 11, 2014 at 4:13 PM, Kamil Debski <k.debski@...sung.com> wrote:
> Hi,
>
>> From: Vivek Gautam [mailto:gautamvivek1987@...il.com]
>> Sent: Thursday, December 11, 2014 7:30 AM
>> To: Kishon Vijay Abraham I; Kamil Debski
>> Cc: linux-kernel@...r.kernel.org; Linux USB Mailing List; Vivek Gautam
>> Subject: Re: [PATCH] phy: phy-samsung-usb2: Don't use same name for
>> driver name and global structure
>>
>> On Wed, Nov 12, 2014 at 3:54 PM, Vivek Gautam <gautam.vivek@...sung.com>
>> wrote:
>> > Using the same driver name for platform driver and a globally defined,
>> > structure used throughout the file, looks a bit unpleasing.
>> > So changing the driver name from "samsung_usb2_phy_driver" to
>> > "samsung_usb2_phy"
>> >
>> > Signed-off-by: Vivek Gautam <gautam.vivek@...sung.com>
>> > Cc: Kamil Debski <k.debski@...sung.com>
>> > Cc: Kishon Vijay Abraham I <kishon@...com>
>> > ---
>>
>> Although just a trivial change, does it look valid ?
>
> I can agree that the naming of this variable is a bit unfortunate.
> Changing name of samsung_usb2_phy_driver to samsung_usb2_phy is, as
> you said, a minor change and does not change how the driver works.
true.

>
> Acked-by: Kamil Debski <k.debski@...sung.com>

Thanks

>
> Best wishes,
> --
> Kamil Debski
> Samsung R&D Institute Poland
>
>>
>> >  drivers/phy/phy-samsung-usb2.c |    4 ++--
>> >  1 file changed, 2 insertions(+), 2 deletions(-)
>> >
>> > diff --git a/drivers/phy/phy-samsung-usb2.c b/drivers/phy/phy-
>> samsung-usb2.c
>> > index 908949d..2934fb7 100644
>> > --- a/drivers/phy/phy-samsung-usb2.c
>> > +++ b/drivers/phy/phy-samsung-usb2.c
>> > @@ -226,7 +226,7 @@ static int samsung_usb2_phy_probe(struct
>> platform_device *pdev)
>> >         return 0;
>> >  }
>> >
>> > -static struct platform_driver samsung_usb2_phy_driver = {
>> > +static struct platform_driver samsung_usb2_phy = {
>> >         .probe  = samsung_usb2_phy_probe,
>> >         .driver = {
>> >                 .of_match_table = samsung_usb2_phy_of_match,
>> > @@ -234,7 +234,7 @@ static struct platform_driver
>> samsung_usb2_phy_driver = {
>> >         }
>> >  };
>> >
>> > -module_platform_driver(samsung_usb2_phy_driver);
>> > +module_platform_driver(samsung_usb2_phy);
>> >  MODULE_DESCRIPTION("Samsung S5P/EXYNOS SoC USB PHY driver");
>> >  MODULE_AUTHOR("Kamil Debski <k.debski@...sung.com>");
>> >  MODULE_LICENSE("GPL v2");
>> > --
>> > 1.7.10.4
>> >
>> > --
>> > To unsubscribe from this list: send the line "unsubscribe linux-
>> kernel" in
>> > the body of a message to majordomo@...r.kernel.org
>> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
>> > Please read the FAQ at  http://www.tux.org/lkml/
>>
>>
>>
>> --
>> Best Regards
>> Vivek Gautam
>> Samsung R&D Institute, Bangalore
>> India
>



-- 
Best Regards
Vivek Gautam
Samsung R&D Institute, Bangalore
India
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/