linux-kernel - Re: [PATCH 4/4] sound: oss: Remove dead sound card number definitions part #2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <s5htx12l4cy.wl-tiwai@suse.de>
Date:	Thu, 11 Dec 2014 14:10:05 +0100
From:	Takashi Iwai <tiwai@...e.de>
To:	Jarkko Nikula <jarkko.nikula@...ux.intel.com>
Cc:	alsa-devel@...a-project.org, Jaroslav Kysela <perex@...ex.cz>,
	linux-api@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/4] sound: oss: Remove dead sound card number definitions part #2

At Thu, 11 Dec 2014 14:19:13 +0200,
Jarkko Nikula wrote:
> 
> None of these is used in kernel tree.
> 
> Signed-off-by: Jarkko Nikula <jarkko.nikula@...ux.intel.com>
> Cc: linux-api@...r.kernel.org
> Cc: linux-kernel@...r.kernel.org
> ---
> RFC, I don't know can these be used in user-space?

I guess we should keep these.  These are fixed ID numbers, no matter
whether the driver actually is present or not.


Takashi

> ---
>  include/uapi/linux/soundcard.h | 22 ----------------------
>  1 file changed, 22 deletions(-)
> 
> diff --git a/include/uapi/linux/soundcard.h b/include/uapi/linux/soundcard.h
> index f3b21f989872..d2256bf4bdd8 100644
> --- a/include/uapi/linux/soundcard.h
> +++ b/include/uapi/linux/soundcard.h
> @@ -48,32 +48,10 @@
>   *	Supported card ID numbers (Should be somewhere else?)
>   */
>  
> -#define SNDCARD_ADLIB		1
>  #define SNDCARD_SB		2
>  #define SNDCARD_PAS		3
> -#define SNDCARD_GUS		4
>  #define SNDCARD_MPU401		5
> -#define SNDCARD_SB16		6
> -#define SNDCARD_SB16MIDI	7
>  #define SNDCARD_UART6850	8
> -#define SNDCARD_GUS16		9
> -#define SNDCARD_MSS		10
> -#define SNDCARD_PSS     	11
> -#define SNDCARD_SSCAPE		12
> -#define SNDCARD_PSS_MPU     	13
> -#define SNDCARD_PSS_MSS     	14
> -#define SNDCARD_SSCAPE_MSS	15
> -#define SNDCARD_TRXPRO		16
> -#define SNDCARD_TRXPRO_SB	17
> -#define SNDCARD_TRXPRO_MPU	18
> -#define SNDCARD_MAD16		19
> -#define SNDCARD_MAD16_MPU	20
> -#define SNDCARD_CS4232		21
> -#define SNDCARD_CS4232_MPU	22
> -#define SNDCARD_MAUI		23
> -#define SNDCARD_PSEUDO_MSS	24
> -#define SNDCARD_GUSPNP		25
> -#define SNDCARD_UART401		26
>  /* Sound card numbers 27 to N are reserved. Don't add more numbers here. */
>  
>  /***********************************
> -- 
> 2.1.3
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/