[<prev] [next>] [day] [month] [year] [list]
Message-ID: <CALCETrU4t1PGodreaunDB1p7FvqhyG5XP=7D+miULn5hXKdTgQ@mail.gmail.com>
Date: Thu, 11 Dec 2014 09:29:33 -0800
From: Andy Lutomirski <luto@...capital.net>
To: marcel@...a.nl
Cc: Andrew Morton <akpm@...ux-foundation.org>,
Alexey Dobriyan <adobriyan@...il.com>,
"Eric W. Biederman" <ebiederm@...ssion.com>,
Oleg Nesterov <oleg@...hat.com>,
Djalal Harouni <tixxdz@...ndz.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] Make /proc/<pid>/io world readable
On Thu, Dec 11, 2014 at 8:22 AM, Marcel Mol <marcel@...a.nl> wrote:
> /proc/<pid>/io is only readable by the pid owner, while files
> like stat, statm and status are world readable.
> I see no reason why io statistics should be hidden.
> This patch makes io also world readable so process io counts
> can be analysed without root permissions.
I'd really rather go the other direction and leak less information to
the world by default.
If we wanted to add a general control to let admins set permissions
for proc files for new processes, that could be useful. Then admins
could set this.
--Andy
>
> Signed-off-by: Marcel Mol <marcel@...a.nl>
> ---
> fs/proc/base.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/proc/base.c b/fs/proc/base.c
> index 772efa4..7bd8dbe 100644
> --- a/fs/proc/base.c
> +++ b/fs/proc/base.c
> @@ -2563,7 +2563,7 @@ static const struct pid_entry tgid_base_stuff[] = {
> REG("coredump_filter", S_IRUGO|S_IWUSR, proc_coredump_filter_operations),
> #endif
> #ifdef CONFIG_TASK_IO_ACCOUNTING
> - ONE("io", S_IRUSR, proc_tgid_io_accounting),
> + ONE("io", S_IRUGO, proc_tgid_io_accounting),
> #endif
> #ifdef CONFIG_HARDWALL
> ONE("hardwall", S_IRUGO, proc_pid_hardwall),
> @@ -2904,7 +2904,7 @@ static const struct pid_entry tid_base_stuff[] = {
> REG("make-it-fail", S_IRUGO|S_IWUSR, proc_fault_inject_operations),
> #endif
> #ifdef CONFIG_TASK_IO_ACCOUNTING
> - ONE("io", S_IRUSR, proc_tid_io_accounting),
> + ONE("io", S_IRUGO, proc_tid_io_accounting),
> #endif
> #ifdef CONFIG_HARDWALL
> ONE("hardwall", S_IRUGO, proc_pid_hardwall),
> --
> 1.9.3
>
>
--
Andy Lutomirski
AMA Capital Management, LLC
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists