linux-kernel - Re: [PATCH -next] coresight-tpiu: use module_amba

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANLsYkyq-4pY9NEsL2dNgNv+FdEPxJ49c8GA_XPUuqpfFhZoag@mail.gmail.com>
Date:	Thu, 11 Dec 2014 10:56:33 -0700
From:	Mathieu Poirier <mathieu.poirier@...aro.org>
To:	weiyj_lk@....com
Cc:	Wei Yongjun <yongjun_wei@...ndmicro.com.cn>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -next] coresight-tpiu: use module_amba_driver to simplify
 the code

On 9 December 2014 at 06:13,  <weiyj_lk@....com> wrote:
> From: Wei Yongjun <yongjun_wei@...ndmicro.com.cn>
>
> module_amba_driver() makes the code simpler by eliminating
> boilerplate code.
>
> Signed-off-by: Wei Yongjun <yongjun_wei@...ndmicro.com.cn>
> ---
>  drivers/coresight/coresight-tpiu.c | 12 +-----------
>  1 file changed, 1 insertion(+), 11 deletions(-)
>
> diff --git a/drivers/coresight/coresight-tpiu.c b/drivers/coresight/coresight-tpiu.c
> index ae10108..3b33af2 100644
> --- a/drivers/coresight/coresight-tpiu.c
> +++ b/drivers/coresight/coresight-tpiu.c
> @@ -201,17 +201,7 @@ static struct amba_driver tpiu_driver = {
>         .id_table       = tpiu_ids,
>  };
>
> -static int __init tpiu_init(void)
> -{
> -       return amba_driver_register(&tpiu_driver);
> -}
> -module_init(tpiu_init);
> -
> -static void __exit tpiu_exit(void)
> -{
> -       amba_driver_unregister(&tpiu_driver);
> -}
> -module_exit(tpiu_exit);
> +module_amba_driver(tpiu_driver);

This looks good - please merge your 4 patches in the same one.

>
>  MODULE_LICENSE("GPL v2");
>  MODULE_DESCRIPTION("CoreSight Trace Port Interface Unit driver");
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/