linux-kernel - Re: [PATCH socfpga-nex] staging: fpga manager: socfpga_fpga

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141211204030.42c33e71@lxorguk.ukuu.org.uk>
Date:	Thu, 11 Dec 2014 20:40:30 +0000
From:	One Thousand Gnomes <gnomes@...rguk.ukuu.org.uk>
To:	kbuild test robot <fengguang.wu@...el.com>
Cc:	Alan Tull <atull@...nsource.altera.com>, kbuild-all@...org,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH socfpga-nex] staging: fpga manager: socfpga_fpga_ops can
 be static

On Thu, 11 Dec 2014 09:43:24 +0800
kbuild test robot <fengguang.wu@...el.com> wrote:

> drivers/staging/fpga/socfpga.c:655:25: sparse: symbol 'socfpga_fpga_ops' was not declared. Should it be static?
> 
> Signed-off-by: Fengguang Wu <fengguang.wu@...el.com>

Ought to be const as well by the look of it - we don't want function
pointers in patchable memory spaces.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/