linux-kernel - Re: [PATCH v2 1/2] sched: add cond_resched

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20141211210649.GR25677@wotan.suse.de>
Date:	Thu, 11 Dec 2014 22:06:49 +0100
From:	"Luis R. Rodriguez" <mcgrof@...e.com>
To:	Jan Beulich <JBeulich@...e.com>
Cc:	"Luis R. Rodriguez" <mcgrof@...not-panic.com>,
	Juergen Gross <JGross@...e.com>, luto@...capital.net,
	david.vrabel@...rix.com, rostedt@...dmis.org,
	masami.hiramatsu.pt@...achi.com, peterz@...radead.org,
	x86@...nel.org, tglx@...utronix.de, xen-devel@...ts.xenproject.org,
	konrad.wilk@...cle.com, mingo@...hat.com,
	Borislav Petkov <bp@...e.de>, bpoirier@...e.de,
	linux-kernel@...r.kernel.org, hpa@...or.com
Subject: Re: [PATCH v2 1/2] sched: add cond_resched_irq()

On Thu, Dec 11, 2014 at 06:31:54AM -0700, Jan Beulich wrote:
> >>> On 11.12.14 at 00:34, <mcgrof@...not-panic.com> wrote:
> > --- a/kernel/sched/core.c
> > +++ b/kernel/sched/core.c
> > @@ -4239,6 +4239,16 @@ int __sched _cond_resched(void)
> >  }
> >  EXPORT_SYMBOL(_cond_resched);
> >  
> > +int __sched cond_resched_irq(void)
> > +{
> > +	if (should_resched()) {
> > +		preempt_schedule_irq();
> > +		return 1;
> > +	}
> > +	return 0;
> > +}
> > +EXPORT_SYMBOL_GPL(cond_resched_irq);
> 
> Do you really want to export to modules a symbol like this?

You mean lets not, true and good point. Let's see if seems
if we go with Andy's suggestion we may not need this anyway.

  Luis
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/