linux-kernel - Re: [PATCH v4 6/6] staging: fpga manager: add driver for altera socfpga manager

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.02.1412111710470.11739@linuxheads99>
Date:	Thu, 11 Dec 2014 17:14:24 -0600
From:	atull <atull@...nsource.altera.com>
To:	Steffen Trumtrar <s.trumtrar@...gutronix.de>
CC:	<gregkh@...uxfoundation.org>, <jgunthorpe@...idianresearch.com>,
	<hpa@...or.com>, <monstr@...str.eu>, <michal.simek@...inx.com>,
	<rdunlap@...radead.org>, <linux-kernel@...r.kernel.org>,
	<devicetree@...r.kernel.org>, <pantelis.antoniou@...sulko.com>,
	<robh+dt@...nel.org>, <grant.likely@...aro.org>,
	<iws@...o.caltech.edu>, <linux-doc@...r.kernel.org>,
	<pavel@...x.de>, <broonie@...nel.org>, <philip@...ister.org>,
	<rubini@...dd.com>, <jason@...edaemon.net>, <kyle.teske@...com>,
	<nico@...aro.org>, <balbi@...com>, <m.chehab@...sung.com>,
	<davidb@...eaurora.org>, <rob@...dley.net>, <davem@...emloft.net>,
	<cesarb@...arb.net>, <sameo@...ux.intel.com>,
	<akpm@...ux-foundation.org>, <linus.walleij@...aro.org>,
	<pawel.moll@....com>, <mark.rutland@....com>,
	<ijc+devicetree@...lion.org.uk>, <galak@...eaurora.org>,
	<delicious.quinoa@...il.com>, <dinguyen@...nsource.altera.com>,
	<yvanderv@...nsource.altera.com>
Subject: Re: [PATCH v4 6/6] staging: fpga manager: add driver for altera
 socfpga manager

On Wed, 10 Dec 2014, Steffen Trumtrar wrote:

> > +static inline void altera_fpga_reg_set_bitsl(struct altera_fpga_priv *priv,
> > +					     u32 offset, u32 bits)
> > +{
> > +	u32 val;
> > +
> > +	val = altera_fpga_reg_readl(priv, offset);
> > +	val |= bits;
> > +	altera_fpga_reg_writel(priv, offset, val);
> > +}
> > +
> > +static inline void altera_fpga_reg_clr_bitsl(struct altera_fpga_priv *priv,
> > +					     u32 offset, u32 bits)
> > +{
> > +	u32 val;
> > +
> > +	val = altera_fpga_reg_readl(priv, offset);
> > +	val &= ~bits;
> > +	altera_fpga_reg_writel(priv, offset, val);
> > +}
> > +
> 
> Why do you need these? Can't you just use regmap_mmio?

I would like to do that as an improvement as time allows, not now.

> > +	ret = request_irq(priv->irq, altera_fpga_isr, 0, "altera-fpga-mgr",
> > +			  priv);
> > +	if (ret < 0)
> > +		goto err_dispose_irq;
> 
> devm_request_irq

Will do, thanks.

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/