[<prev] [next>] [day] [month] [year] [list]
Message-id: <548908C2.1060906@samsung.com>
Date: Thu, 11 Dec 2014 08:30:18 +0530
From: Pankaj Dubey <pankaj.dubey@...sung.com>
To: Yadwinder Singh Brar <yadi.brar01@...il.com>
Cc: "linux-arm-kernel@...ts.infradead.org"
<linux-arm-kernel@...ts.infradead.org>,
linux-samsung-soc <linux-samsung-soc@...r.kernel.org>,
linux-kernel <linux-kernel@...r.kernel.org>,
Kukjin Kim <kgene.kim@...sung.com>,
Russell King <linux@....linux.org.uk>,
Heiko Stübner <heiko@...ech.de>,
Arnd Bergmann <arnd@...db.de>,
Linus Walleij <linus.walleij@...aro.org>,
Tomasz Figa <tomasz.figa@...il.com>,
Rob Herring <robh+dt@...nel.org>, thomas.ab@...sung.com,
Grant Likely <grant.likely@...aro.org>
Subject: Re: [PATCH v4 1/2] soc: samsung: add exynos chipid driver support
Hi Yadwinder,
On Thursday 04 December 2014 11:56 PM, Yadwinder Singh Brar wrote:
> Hi Pankaj,
>
>
> On Wed, Dec 3, 2014 at 1:47 PM, Pankaj Dubey <pankaj.dubey@...sung.com
> <mailto:pankaj.dubey@...sung.com>> wrote:
>
> Exynos SoCs have Chipid, for identification of product IDs
> and SoC revisions. This patch intendes to provide initialization
> code for all these functionalites, at the same time it provides some
> sysfs entries for accessing these information to userspace.
>
> This driver usese existing binding for exnos-chipid.
>
> [ ... ]
>
> +
> +static unsigned int soc_product_id;
> +static unsigned int soc_revision;
> +
> +int exynos_product_id(void)
> +{
> + return soc_product_id;
> +}
> +EXPORT_SYMBOL(exynos_product_id);
> +
> +int exynos_revision(void)
> +{
> + return soc_revision;
> +}
> +EXPORT_SYMBOL(exynos_revision);
> +
>
>
> How about exporting only a struct containing members : soc_revision,
> soc_product_id
OK, keeping in mind that chipid driver might be used from other drivers
as well (such as asv) other than from mach-exynos, we can do this.
> and may be some more like asv/fused_info and keeping these function as
Other members such as fused_info etc. can be added as and when required.
As of now there is no active user of all those.
> inlines ?
>
> +static const char *exynos_product_id_to_name(unsigned int product_id)
>
>
> __init ? hmm .. I think almost whole driver other than __ATTR funcs.
>
OK, I'll take care of this in next patch version.
> Otherwise it looks nice to me :)
>
> Best Regards,
> Yadwinder
Thanks for review.
Pankaj Dubey
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists