linux-kernel - Re: [GIT PULL] bulk GPIO changes for v3.19

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 12 Dec 2014 11:19:59 +0100
From:	Linus Walleij <linus.walleij@...aro.org>
To:	Linus Torvalds <torvalds@...ux-foundation.org>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
	Alexandre Courbot <gnurou@...il.com>
Subject: Re: [GIT PULL] bulk GPIO changes for v3.19

On Thu, Dec 11, 2014 at 8:34 PM, Linus Torvalds
<torvalds@...ux-foundation.org> wrote:
> On Tue, Dec 9, 2014 at 1:09 AM, Linus Walleij <linus.walleij@...aro.org> wrote:
>>
>> here is the bulk of GPIO changes for the v3.19 kernel series.
>> The major external change is the new API to driver several GPIOs
>> simultaneously, and the major internal change is that we're getting
>> rid of a static array of GPIO descriptors and again moving away,
>> slowly, from the global GPIO numberspace.
>
> This does not build for me.
>
> The gpio-mcp23s08.c driver now has a "chip.of_node" access outside of
> #ifdef CONFIG_OF, resulting in
>
>   drivers/gpio/gpio-mcp23s08.c: In function ‘mcp23s08_probe_one’:
>   drivers/gpio/gpio-mcp23s08.c:658:57: error: ‘struct gpio_chip’ has
> no member named ‘of_node’
>      mcp->irq_active_high = of_property_read_bool(mcp->chip.of_node,

Grr how could I miss this. I'll fix up stuff.

> Should it be using "mcp->chip.dev->of_node" instead? Or should the
> driver just depend on OF?

The former I think, the driver has only optional DT support.

I will fix up and send a new pull request when finished.

Maybe I should not have the of_node inside #ifdef CONFIG_OF in
the gpio_chip and just keep it around like we do in struct device,
that makes for less #ifdef clutter.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/