[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Fri, 12 Dec 2014 13:34:57 +0000
From: Mark Brown <broonie@...nel.org>
To: Ben Zhang <benzh@...omium.org>
Cc: alsa-devel@...a-project.org, Liam Girdwood <lgirdwood@...il.com>,
Bard Liao <bardliao@...ltek.com>,
Oder Chiou <oder_chiou@...ltek.com>,
Anatol Pomozov <anatol@...gle.com>,
Dylan Reid <dgreid@...omium.org>,
Albert Chen <albertchen@...ltek.com>,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/3] ASoC: rt5677: add a platform config option for
DACREF source
On Wed, Dec 10, 2014 at 08:15:27PM -0800, Ben Zhang wrote:
> DACREF power source can come from external 1.8V or codec internal 1.8V.
> This patch adds the option to enable the internal DACREF power source.
> +- realtek,internal-dacref-en
> + Select codec internal 1.8V as DACREF source optionally.
> +
Why is this not done using the regulator API - don't we need to ensure
that the external DACREF is enabled if it's there? I don't think we
need to model the internal reference as a regulator (we can just set
the registers up in that case) but if it's off device I'd expect to be
making sure that it's turned on.
Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)
Powered by blists - more mailing lists