[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Date: Fri, 12 Dec 2014 11:42:54 -0500
From: Jason Cooper <jason@...edaemon.net>
To: Eddie Huang <eddie.huang@...iatek.com>
Cc: Mark Rutland <mark.rutland@....com>,
Matthias Brugger <matthias.bgg@...il.com>,
Rob Herring <robh+dt@...nel.org>,
"srv_heupstream@...iatek.com" <srv_heupstream@...iatek.com>,
Pawel Moll <Pawel.Moll@....com>,
Ian Campbell <ijc+devicetree@...lion.org.uk>,
Kumar Gala <galak@...eaurora.org>,
Catalin Marinas <Catalin.Marinas@....com>,
Will Deacon <Will.Deacon@....com>,
Thomas Gleixner <tglx@...utronix.de>,
Olof Johansson <olof@...om.net>,
"Joe.C" <yingjoe.chen@...iatek.com>,
Robert Richter <rrichter@...ium.com>,
Mark Brown <broonie@...aro.org>,
"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"linux-arm-kernel@...ts.infradead.org"
<linux-arm-kernel@...ts.infradead.org>,
Sascha Hauer <kernel@...gutronix.de>,
"yh.chen@...iatek.com" <yh.chen@...iatek.com>
Subject: Re: [PATCH 3/4] arm64: dts: Add mediatek MT8173 SoC and evaluation
board dts and Makefile
On Fri, Dec 12, 2014 at 04:08:25PM +0800, Eddie Huang wrote:
> On Thu, 2014-12-11 at 18:02 +0000, Mark Rutland wrote:
> > On Wed, Dec 10, 2014 at 10:50:01AM +0000, Eddie Huang wrote:
...
> > > + memory {
> >
> > Nit: should be memory@...00000 (and you'll need to add device_type =
> > "memory").
> >
> > > + reg = <0 0x40000000 0 0x40000000>;
> > > + };
>
> skeleton.dtsi already has /memory node with address-cells=2,
> size-cells=1, which will cause build warning if I change to use
> memory@...00000, because we use size-cells=2. I will not include
> skeleton.dtsi and follow your suggestion in next version.
There's skeleton64.dtsi in arch/arm/boot/dts (arm 32bit has LPAE-enabled
systems). Perhaps we should come up with a way to share both across the
arches?
hth,
Jason.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists