lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Sat, 13 Dec 2014 09:55:18 -0800
From:	Jeremiah Mahler <jmmahler@...il.com>
To:	Loic Pefferkorn <loic@...cp.eu>
Cc:	gregkh@...uxfoundation.org, alan@...ux.intel.com,
	jun.j.tian@...el.com, octavian.purdila@...el.com, nnk@...gle.com,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: goldfish: Fix minor coding style

Loic,

On Sat, Dec 13, 2014 at 05:29:26PM +0100, Loic Pefferkorn wrote:
> Hello,
> 
> The convention for checking for NULL pointers is !ptr and not ptr == NULL.
> This patch fixes such occurences in goldfish driver, it applies against next-20141212
> 
Whose convention is this?  I can't find any mention in
Documention/CodingStyle. checkpatch.pl doesn't complain about them.
And there are almost three thousand examples in staging which don't
use this convention.

  linux-next$ grep -r "== NULL" drivers/staging/* | wc -l
  2844

> 
> Signed-off-by: Loic Pefferkorn <loic@...cp.eu>
> ---
>  drivers/staging/goldfish/goldfish_audio.c |  8 ++++----
>  drivers/staging/goldfish/goldfish_nand.c  | 10 +++++-----
>  2 files changed, 9 insertions(+), 9 deletions(-)
> 
> diff --git a/drivers/staging/goldfish/goldfish_audio.c b/drivers/staging/goldfish/goldfish_audio.c
> index f200359..7ab034b 100644
> --- a/drivers/staging/goldfish/goldfish_audio.c
> +++ b/drivers/staging/goldfish/goldfish_audio.c
> @@ -273,19 +273,19 @@ static int goldfish_audio_probe(struct platform_device *pdev)
>  	dma_addr_t buf_addr;
>  
>  	data = devm_kzalloc(&pdev->dev, sizeof(*data), GFP_KERNEL);
> -	if (data == NULL)
> +	if (!data)
>  		return -ENOMEM;
>  	spin_lock_init(&data->lock);
>  	init_waitqueue_head(&data->wait);
>  	platform_set_drvdata(pdev, data);
>  
>  	r = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -	if (r == NULL) {
> +	if (!r) {
>  		dev_err(&pdev->dev, "platform_get_resource failed\n");
>  		return -ENODEV;
>  	}
>  	data->reg_base = devm_ioremap(&pdev->dev, r->start, PAGE_SIZE);
> -	if (data->reg_base == NULL)
> +	if (!data->reg_base)
>  		return -ENOMEM;
>  
[...]

-- 
- Jeremiah Mahler
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists