[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20141213101753.GA9290@newt.localdomain>
Date: Sat, 13 Dec 2014 02:17:53 -0800
From: Jeremiah Mahler <jmmahler@...il.com>
To: Dudley Du <dudley.dulixin@...il.com>
Cc: linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v14 00/12] input: cyapa: instruction of cyapa patches
Dudley,
On Fri, Dec 12, 2014 at 10:27:30AM +0800, Dudley Du wrote:
> V14 patches have below updates, details of other updates see history list:
> 1) Correct 9 miss spelling issues of "bufferred" to "buffered".
> 2) Fix the upgrade issue of removing MOUSE_CYAPA config when make oldconfig
> by replase "depends on I2C && CRC_ITU_T" with
> "depends on I2C"
> "select CRC_ITU_T"
> in patch 9.
>
[...]
I found some sparse warnings that should be fixed.
jeri@...t:~/linux-next$ touch drivers/input/mouse/*.c
jeri@...t:~/linux-next$ touch drivers/input/mouse/*.h
jeri@...t:~/linux-next$ make C=1
CHK include/config/kernel.release
CHK include/generated/uapi/linux/version.h
CHK include/generated/utsrelease.h
CALL scripts/checksyscalls.sh
CHK include/generated/compile.h
CHK kernel/config_data.h
CHECK drivers/input/mouse/cyapa.c
drivers/input/mouse/cyapa.c:43:9: warning: symbol 'cyapa_i2c_read' was
not declared. Should it be static?
drivers/input/mouse/cyapa.c:80:9: warning: symbol 'cyapa_i2c_write' was
not declared. Should it be static?
drivers/input/mouse/cyapa.c:289:5: warning: symbol 'cyapa_detect' was
not declared. Should it be static?
CC [M] drivers/input/mouse/cyapa.o
CHECK drivers/input/mouse/cyapa_gen3.c
drivers/input/mouse/cyapa_gen3.c:299:5: warning: symbol
'cyapa_read_byte' was not declared. Should it be static?
drivers/input/mouse/cyapa_gen3.c:312:5: warning: symbol
'cyapa_write_byte' was not declared. Should it be static?
drivers/input/mouse/cyapa_gen3.c:331:9: warning: symbol
'cyapa_i2c_reg_write_block' was not declared. Should it be static?
CC [M] drivers/input/mouse/cyapa_gen3.o
CHECK drivers/input/mouse/cyapa_gen5.c
drivers/input/mouse/cyapa_gen5.c:334:5: warning: symbol
'cyapa_empty_pip_output_data' was not declared. Should it be static?
drivers/input/mouse/cyapa_gen5.c:553:6: warning: symbol
'cyapa_gen5_sort_tsg_pip_bl_resp_data' was not declared. Should it be
static?
drivers/input/mouse/cyapa_gen5.c:568:6: warning: symbol
'cyapa_gen5_sort_tsg_pip_app_resp_data' was not declared. Should it be
static?
drivers/input/mouse/cyapa_gen5.c:595:6: warning: symbol
'cyapa_gen5_sort_application_launch_data' was not declared. Should it be
static?
drivers/input/mouse/cyapa_gen5.c:995:6: warning: symbol
'cyapa_gen5_sort_bl_exit_data' was not declared. Should it be static?
drivers/input/mouse/cyapa_gen5.c:1112:72: warning: Using plain integer
as NULL pointer
CC [M] drivers/input/mouse/cyapa_gen5.o
LD [M] drivers/input/mouse/cyapatp.o
Kernel: arch/x86/boot/bzImage is ready (#127)
Building modules, stage 2.
MODPOST 187 modules
CC drivers/input/mouse/cyapatp.mod.o
LDFINAL [M] drivers/input/mouse/cyapatp.ko
jeri@...t:~/linux-next
--
- Jeremiah Mahler
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists