linux-kernel - RE: [PATCH v4 3/3] gpio: add support for Cypress CYUSBS234 USB-GPIO adapter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 13 Dec 2014 11:50:08 +0000
From:	Muthu Mani <muth@...ress.com>
To:	Linus Walleij <linus.walleij@...aro.org>
CC:	Samuel Ortiz <sameo@...ux.intel.com>,
	Lee Jones <lee.jones@...aro.org>,
	Wolfram Sang <wsa@...-dreams.de>,
	Alexandre Courbot <gnurou@...il.com>,
	"Johan Hovold" <johan@...nel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-i2c@...r.kernel.org" <linux-i2c@...r.kernel.org>,
	"linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
	Rajaram Regupathy <rera@...ress.com>
Subject: RE: [PATCH v4 3/3] gpio: add support for Cypress CYUSBS234 USB-GPIO
 adapter

> (..)
> > +config GPIO_CYUSBS23X
> > +       tristate "CYUSBS23x GPIO support"
> > +       depends on MFD_CYUSBS23X && USB
>
> Doesn't MFD_CYUSV23X already depend on USB?

Yes, removed USB from GPIO and I2C

> > +       if (gpio->out_gpio & (1 << offset))
> > +               return gpio->out_value & (1 << offset);
>
> Rewrite like this:
>
> if (gpio->out_gpio & BIT(offset))
>              return !!(gpio->out_value & BIT(offset));

Ok, updated for all instances.

Incorporated the comments and posted v5 patch.

Regards,
Muthu

This message and any attachments may contain Cypress (or its subsidiaries) confidential information. If it has been received in error, please advise the sender and immediately delete this message.