linux-kernel - Re: [PATCH 1/3] tracepoints: Do not use call_rcu_sched() before early

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141214132556.6f8d6fb9@gandalf.local.home>
Date:	Sun, 14 Dec 2014 13:25:56 -0500
From:	Steven Rostedt <rostedt@...dmis.org>
To:	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>
Cc:	linux-kernel@...r.kernel.org,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Ingo Molnar <mingo@...nel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Mathieu Desnoyers <mathieu.desnoyers@...icios.com>
Subject: Re: [PATCH 1/3] tracepoints: Do not use call_rcu_sched() before
 early_initcall()

On Sun, 14 Dec 2014 10:18:35 -0800
"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com> wrote:

> > With your feed back, and because I would like this to go into 3.19, I
> > would like to keep the current patch as is (with the read_mostly
> > update, which I'm currently testing). We can always change it later
> > after call_rcu() has been changed.
> 
> Completely agreed!  ;-)

For this late in the game, we need to play it safe.

I got rid of my tracepoint patch and moved trace_init() to after
rcu_init(), which I think is good enough for Thomas. Thomas?

I'll start testing that now.

Later, if you could add a rcu_init() version that lets us call
call_rcu_sched() just after mm_init() then we could move trace_init()
up a bit more.

Thanks,

-- Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/