linux-kernel - Re: [patch 2/2] ALSA: oxfw: fix detect_loud

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <s5hh9wy5l0o.wl-tiwai@suse.de>
Date:	Sun, 14 Dec 2014 16:05:59 +0100
From:	Takashi Iwai <tiwai@...e.de>
To:	Takashi Sakamoto <o-takashi@...amocchi.jp>
Cc:	Dan Carpenter <dan.carpenter@...cle.com>,
	Clemens Ladisch <clemens@...isch.de>,
	Jaroslav Kysela <perex@...ex.cz>, alsa-devel@...a-project.org,
	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [patch 2/2] ALSA: oxfw: fix detect_loud_models() return value

At Sat, 13 Dec 2014 13:45:55 +0900,
Takashi Sakamoto wrote:
> 
> On Dec 13 2014 04:28, Dan Carpenter wrote:
> > This code causes a static checker warning:
> > 
> > 	sound/firewire/oxfw/oxfw.c:46 detect_loud_models()
> > 	warn: signedness bug returning '(-2)'
> > 
> > The detect_loud_models() function should return false on falure, so that
> > we don't try to set up the loud code for hardware that doesn't support
> > it.
> > 
> > Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>
> > 
> > diff --git a/sound/firewire/oxfw/oxfw.c b/sound/firewire/oxfw/oxfw.c
> > index cf1d0b5..60e5cad 100644
> > --- a/sound/firewire/oxfw/oxfw.c
> > +++ b/sound/firewire/oxfw/oxfw.c
> > @@ -43,7 +43,7 @@ static bool detect_loud_models(struct fw_unit *unit)
> >  	err = fw_csr_string(unit->directory, CSR_MODEL,
> >  			    model, sizeof(model));
> >  	if (err < 0)
> > -		return err;
> > +		return false;
> >  
> >  	for (i = 0; i < ARRAY_SIZE(models); i++) {
> >  		if (strcmp(models[i], model) == 0)
> 
> Reviewd-by: Takashi Sakamoto <o-takashi@...amocchi.jp>

Applied this one now.  Thanks.

(The second one is still pending, waiting for the final decision for a
 while.)


Takashi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/