linux-kernel - Re: [PATCH v10 1/8] tpm: merge duplicate transmit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 14 Dec 2014 16:31:10 +0100
From:	peterhuewe@....de
To:	Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>,
	Stefan Berger <stefanb@...ux.vnet.ibm.com>
CC:	Ashley Lai <ashley@...leylai.com>,
	Marcel Selhorst <tpmdd@...horst.net>,
	tpmdd-devel@...ts.sourceforge.net, linux-kernel@...r.kernel.org,
	josh@...htriplett.org, christophe.ricard@...il.com,
	jason.gunthorpe@...idianresearch.com, linux-api@...r.kernel.org,
	trousers-tech@...ts.sourceforge.net
Subject: Re: [PATCH v10 1/8] tpm: merge duplicate transmit_cmd() functions



On 14. Dezember 2014 15:57:10 MEZ, Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com> wrote:
>On Sun, 2014-12-14 at 09:03 -0500, Stefan Berger wrote:
>> On 12/12/2014 02:46 PM, Jarkko Sakkinen wrote:
>> > Merged transmit_cmd() functions in tpm-interface.c and tpm-sysfs.c.
>> > Added "tpm_" prefix for consistency sake. Changed cmd parameter as
>> > opaque. This enables to use separate command structures for TPM1
>> > and TPM2 commands in future. Loose coupling works fine here.
>> >
>> > Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
>> > Reviewed-by: Jasob Gunthorpe <jason.gunthorpe@...idianresearch.com>
>> > Reviewed-by: Stephan Berger <stephan.berger@...ux.vnet.ibm.com>
>> 
>> Not quite ... Stefan Berger <stefanb@...ux.vnet.ibm.com>
>
>Oops. Peter, I guess you could fix those or? My apologies.
>
>>      Stefan
>
>/Jarkko
I'll fix this,
No problem.
Peter
-- 
Sent from my mobile.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/