linux-kernel - Re: [PATCH] usb: host: max3421-hcd: use time

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CALnQHM0c_-NG9FPbsWun+yK6PVgYVQjRzE4jGEXEQ4E-yqsfpA@mail.gmail.com>
Date:	Mon, 15 Dec 2014 08:50:36 +0100
From:	David Mosberger <davidm@...uge.net>
To:	Asaf Vertz <asaf.vertz@...demg.com>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Alexey Khoroshilov <khoroshilov@...ras.ru>,
	Sachin Kamat <sachin.kamat@...aro.org>,
	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] usb: host: max3421-hcd: use time_after()

Acked-by: David Mosberger <davidm@...uge.net>

On Mon, Dec 15, 2014 at 8:22 AM, Asaf Vertz <asaf.vertz@...demg.com> wrote:
> To be future-proof and for better readability the time comparisons are
> modified to use time_after() instead of plain, error-prone math.
>
> Signed-off-by: Asaf Vertz <asaf.vertz@...demg.com>
> ---
>  drivers/usb/host/max3421-hcd.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/usb/host/max3421-hcd.c b/drivers/usb/host/max3421-hcd.c
> index 6234c75..aaaff94 100644
> --- a/drivers/usb/host/max3421-hcd.c
> +++ b/drivers/usb/host/max3421-hcd.c
> @@ -55,6 +55,7 @@
>   * single thread (max3421_spi_thread).
>   */
>
> +#include <linux/jiffies.h>
>  #include <linux/module.h>
>  #include <linux/spi/spi.h>
>  #include <linux/usb.h>
> @@ -1291,7 +1292,7 @@ max3421_handle_irqs(struct usb_hcd *hcd)
>                 char sbuf[16 * 16], *dp, *end;
>                 int i;
>
> -               if (jiffies - last_time > 5*HZ) {
> +               if (time_after(jiffies, last_time + 5*HZ)) {
>                         dp = sbuf;
>                         end = sbuf + sizeof(sbuf);
>                         *dp = '\0';
> --
> 1.7.0.4
>



-- 
eGauge Systems LLC, http://egauge.net/, 1.877-EGAUGE1, fax 720.545.9768
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/