linux-kernel - Re: [PATCH 00/18] uaccess: fix sparse warning on get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAFiDJ5_fGWx2E1jvU+k0Tv_esRpWmC-p+kq7Y_VOr5bx2ZUFzg@mail.gmail.com>
Date:	Mon, 15 Dec 2014 18:03:10 +0800
From:	"LF.Tan" <lftan.linux@...il.com>
To:	"Michael S. Tsirkin" <mst@...hat.com>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Arnd Bergmann <arnd@...db.de>,
	Linux-Arch <linux-arch@...r.kernel.org>
Subject: Re: [PATCH 00/18] uaccess: fix sparse warning on get_user for bitwise types

On Mon, Dec 15, 2014 at 12:51 AM, Michael S. Tsirkin <mst@...hat.com> wrote:
> At the moment, if p and x are both tagged as bitwise types,
> get_user(x, p) produces a sparse warning on many architectures.
> This is because *p on these architectures is loaded into long
> (typically using asm), then cast back to typeof(*p).
>
> When typeof(*p) is a bitwise type (which is uncommon), such a cast needs
> __force, otherwise sparse produces a warning.
>
> Some architectures already have the __force tag, add it
> where it's missing.
>
> Specificlly, vhost wants to read bitwise types from userspace using get_user.
> At the moment this triggers sparse errors, since the value is passed through an
> integer.
>
> For now, I worked around this by converting vhost code to access_ok +
> __get_user, but that's not robust, I'd like to switch to get_user for 3.19.
>
> I tested this on x86 only so far. Since it's just adding __force, should be
> trivially safe everywhere?
>
> Please review, and consider for 3.19.
>
> Who can merge this? Arnd?
Hi Michael

FYI, there is new arch (arch/nios2) in 3.19. Is your patchset include
the fix for it?
Thanks.

Regards
Ley Foon
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/