linux-kernel - Re: [PATCH v3 1/2] iio: document ti-dac8554 devicetree bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141215130248.GA8264@leverpostej>
Date:	Mon, 15 Dec 2014 13:02:48 +0000
From:	Mark Rutland <mark.rutland@....com>
To:	Nikolaus Schulz <nikolaus.schulz@...onic-design.de>
Cc:	"linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>,
	Rob Herring <robh+dt@...nel.org>,
	Pawel Moll <Pawel.Moll@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Alban Bedel <alban.bedel@...onic-design.de>
Subject: Re: [PATCH v3 1/2] iio: document ti-dac8554 devicetree bindings

On Mon, Dec 15, 2014 at 11:39:56AM +0000, Nikolaus Schulz wrote:
> Signed-off-by: Nikolaus Schulz <nikolaus.schulz@...onic-design.de>
> ---
>  .../devicetree/bindings/iio/dac/ti-dac8554.txt     | 22 ++++++++++++++++++++++
>  1 file changed, 22 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/iio/dac/ti-dac8554.txt
> 
> diff --git a/Documentation/devicetree/bindings/iio/dac/ti-dac8554.txt b/Documentation/devicetree/bindings/iio/dac/ti-dac8554.txt
> new file mode 100644
> index 0000000..32e96859
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/dac/ti-dac8554.txt
> @@ -0,0 +1,22 @@
> +TI DAC8554 Digital to Analog Converter
> +
> +This driver supports the SPI bus.

The binding need not refer to the driver, this sentence can go. It might
be worth adding "(SPI)" to the first line.

> +
> +Required properties:
> +	- compatible: must be "ti,dac8554"
> +	- vref-supply: the vref power supply
> +	- ti,address: the additional 2-bit chip address
> +
> +For required properties on SPI, please consult
> +Documentation/devicetree/bindings/spi/spi-bus.txt
> +
> +Example:
> +
> +	dac8554@0 {
> +		compatible = "ti,dac8554";
> +		reg = <0>;
> +		spi-max-frequency = <50000000>;
> +
> +		vref-supply = <&vdd_vref>;
> +		ti,address = <0>;

What's this property used for?

> +	};

Otherwise this looks sane to me.

Mark.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/