[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20141215090404.6d5cb86e@lwn.net>
Date: Mon, 15 Dec 2014 09:04:04 -0500
From: Jonathan Corbet <corbet@....net>
To: Geert Uytterhoeven <geert@...ux-m68k.org>
Cc: Mauro Carvalho Chehab <mchehab@....samsung.com>,
linux-media@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH/RESEND] [media] VIDEO_CAFE_CCIC should select
VIDEOBUF2_DMA_SG
On Mon, 15 Dec 2014 14:55:37 +0100
Geert Uytterhoeven <geert@...ux-m68k.org> wrote:
> If VIDEO_CAFE_CCIC=y, but VIDEOBUF2_DMA_SG=m:
>
> drivers/built-in.o: In function `mcam_v4l_open':
> mcam-core.c:(.text+0x1c2e81): undefined reference to `vb2_dma_sg_memops'
> mcam-core.c:(.text+0x1c2eb0): undefined reference to `vb2_dma_sg_init_ctx'
> drivers/built-in.o: In function `mcam_v4l_release':
> mcam-core.c:(.text+0x1c34bf): undefined reference to `vb2_dma_sg_cleanup_ctx'
I've been mildly resistant to this because I've never figured out how
such a configuration can come about. The Cafe chip only appeared in the
OLPC XO-1 and cannot even come close to doing S/G I/O. So this patch
robs a bit of memory for no use on a platform that can ill afford it.
OTOH, the number of people building contemporary kernels for the XO-1 has
got to be pretty small. So, in the interest of mollifying randconfig
users out there, you can add my:
Acked-by: Jonathan Corbet <corbet@....net>
jon
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists