linux-kernel - Re: [PATCH] drivers:block: Remove no longer needed FIXME comment for the function, add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <548E4D34.6000108@kernel.dk>
Date:	Sun, 14 Dec 2014 19:53:40 -0700
From:	Jens Axboe <axboe@...nel.dk>
To:	nick <xerofoify@...il.com>
CC:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers:block: Remove no longer needed FIXME comment
 for the function, add_disk in genhd.c

On 12/14/2014 07:46 PM, nick wrote:
> Jens,
> After rechecking the function definition we can't return an error as add_disk is declared void. Should I change the function to an int and then return an error. My thinking was that there is no good way to return an error code without
> a breakage in the functions that  call add_disk.

Please don't top post...

It's a big job, it requires properly checking and updating all block 
drivers. But yes, that is what would be required in removing that TODO.

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/