lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 15 Dec 2014 10:48:45 -0500 From: Jes Sorensen <Jes.Sorensen@...hat.com> To: Dan Carpenter <dan.carpenter@...cle.com> Cc: Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>, Larry Finger <Larry.Finger@...inger.net>, devel@...verdev.osuosl.org, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, linux-wireless@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] staging: rtl8723au: os_dep: usb_intf.c: Fix for possible null pointer dereference Dan Carpenter <dan.carpenter@...cle.com> writes: > On Sun, Dec 14, 2014 at 11:39:14PM +0100, Rickard Strandqvist wrote: >> There is otherwise a risk of a possible null pointer dereference. >> >> Was largely found by using a static code analysis program called cppcheck. >> >> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se> >> --- >> drivers/staging/rtl8723au/os_dep/usb_intf.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/staging/rtl8723au/os_dep/usb_intf.c >> b/drivers/staging/rtl8723au/os_dep/usb_intf.c >> index 865743e..71a6330 100644 >> --- a/drivers/staging/rtl8723au/os_dep/usb_intf.c >> +++ b/drivers/staging/rtl8723au/os_dep/usb_intf.c >> @@ -351,10 +351,11 @@ error_exit: >> int rtw_hw_resume23a(struct rtw_adapter *padapter) > > That's weird. Is this function even called? [jes@...rasam jes.git]$ find drivers/staging/rtl8723au -name \*.[ch] |xargs grep rtw_hw_resume drivers/staging/rtl8723au/include/osdep_intf.h:int rtw_hw_resume23a(struct rtw_adapter *padapter); drivers/staging/rtl8723au/os_dep/usb_intf.c:int rtw_hw_resume23a(struct rtw_adapter *padapter) drivers/staging/rtl8723au/os_dep/usb_intf.c: DBG_8723A("==> rtw_hw_resume23a\n"); [jes@...rasam jes.git]$ find drivers/staging/rtl8723au -name \*.[ch] |xargs grep rtw_hw_suspend drivers/staging/rtl8723au/include/osdep_intf.h:int rtw_hw_suspend23a(struct rtw_adapter *padapter); drivers/staging/rtl8723au/os_dep/usb_intf.c:int rtw_hw_suspend23a(struct rtw_adapter *padapter) drivers/staging/rtl8723au/os_dep/usb_intf.c: DBG_8723A("==> rtw_hw_suspend23a\n"); A more useful patch would be one removing those two functions IMHO. Jes -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists