linux-kernel - Re: [PATCH] net: stmmac: sti: Fix uninitialized pointer dereference if !OF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20141215.114829.885744524649941189.davem@davemloft.net>
Date:	Mon, 15 Dec 2014 11:48:29 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	geert@...ux-m68k.org
Cc:	peppe.cavallaro@...com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: stmmac: sti: Fix uninitialized pointer
 dereference if !OF

From: Geert Uytterhoeven <geert@...ux-m68k.org>
Date: Mon, 15 Dec 2014 12:25:51 +0100

> If CONFIG_OF is not set:
> 
> drivers/net/ethernet/stmicro/stmmac/dwmac-sti.c: In function ‘sti_dwmac_parse_data’:
> drivers/net/ethernet/stmicro/stmmac/dwmac-sti.c:318: warning: ‘rs’ is used uninitialized in this function
> 
> of_property_read_string() will return -ENOSYS in this case, and rs will
> be an uninitialized pointer.
> 
> While the fallback clock selection is already selected correctly in this
> case, the string comparisons should be skipped too, else the system will
> crash while dereferencing the uninitialized pointer.
> 
> Signed-off-by: Geert Uytterhoeven <geert@...ux-m68k.org>

Applied.