linux-kernel - Re: [PATCH] Staging: rtl8712: removed an unnecessary else statement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1418664431.2674.19.camel@perches.com>
Date:	Mon, 15 Dec 2014 09:27:11 -0800
From:	Joe Perches <joe@...ches.com>
To:	Larry Finger <Larry.Finger@...inger.net>
Cc:	Karthik Nayak <karthik.188@...il.com>, trivial@...nel.org,
	linux-kernel@...r.kernel.org, gregkh@...uxfoundation.org
Subject: Re: [PATCH] Staging: rtl8712: removed an unnecessary else statement

On Mon, 2014-12-15 at 11:12 -0600, Larry Finger wrote:
> On 12/15/2014 10:39 AM, Joe Perches wrote:
> > On Mon, 2014-12-15 at 20:55 +0530, Karthik Nayak wrote:
> >> As per checkpatch warning, removed an unnecessary else statement
> >> proceeding an if statement with a return.
> >
> > This is not a correct change.
> > The checkpatch message said "generally".
> > You still have to verify the code.
[]
> Perhaps checkpatch should ignore setting this warning when there is an "else if" 
> in the flow.

In a patch, that's not possible as the
context may not show the flow.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/