linux-kernel - Re: [PATCH 3/6] hwmon: jc42: use bitops' sign

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141215212948.GA23765@roeck-us.net>
Date:	Mon, 15 Dec 2014 13:29:48 -0800
From:	Guenter Roeck <linux@...ck-us.net>
To:	Martin Kepplinger <martink@...teo.de>
Cc:	peterz@...radead.org, mingo@...nel.org, tytso@....edu,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/6] hwmon: jc42: use bitops' sign_extend16

On Mon, Dec 15, 2014 at 05:18:34PM +0100, Martin Kepplinger wrote:
> ---

Some description would be nice. Also, please consider adding
relevant subsystem mailing lists and maintainers to your patches.

>  drivers/hwmon/jc42.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/hwmon/jc42.c b/drivers/hwmon/jc42.c
> index 388f8bc..335a2de 100644
> --- a/drivers/hwmon/jc42.c
> +++ b/drivers/hwmon/jc42.c
> @@ -31,6 +31,7 @@
>  #include <linux/hwmon-sysfs.h>
>  #include <linux/err.h>
>  #include <linux/mutex.h>
> +#include <linux/bitops.h>
>  
>  /* Addresses to scan */
>  static const unsigned short normal_i2c[] = {
> @@ -215,9 +216,7 @@ static int jc42_temp_from_reg(s16 reg)
>  {
>  	reg &= 0x1fff;
>  
If I understand the code in sign_extend16 correctly, the above mask
should no longer be necessary.

Thanks,
Guenter

> -	/* sign extend register */
> -	if (reg & 0x1000)
> -		reg |= 0xf000;
> +	reg = sign_extend16(reg, 12);
>  
>  	/* convert from 0.0625 to 0.001 resolution */
>  	return reg * 125 / 2;
> -- 
> 2.1.3
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/