linux-kernel - Re: [PATCH 3.18 15/19] move d_rcu from overlapping d_child to overlapping d

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141215213312.GV22149@ZenIV.linux.org.uk>
Date:	Mon, 15 Dec 2014 21:33:12 +0000
From:	Al Viro <viro@...IV.linux.org.uk>
To:	Josh Boyer <jwboyer@...oraproject.org>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-kernel@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH 3.18 15/19] move d_rcu from overlapping d_child to
 overlapping d_alias

On Mon, Dec 15, 2014 at 10:46:50AM -0500, Josh Boyer wrote:
> On Sun, Dec 14, 2014 at 12:21:26PM -0800, Greg Kroah-Hartman wrote:
> >3.18-stable review patch.  If anyone has any objections, please let me know.
> >
> >------------------
> >
> >From: Al Viro <viro@...iv.linux.org.uk>
> >
> >commit 946e51f2bf37f1656916eb75bd0742ba33983c28 upstream.
> >
> >Signed-off-by: Al Viro <viro@...iv.linux.org.uk>
> >Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> 
> I noticed you don't have this (and the child commit) queued for 3.17.y.
> The backport wasn't exactly straight-forward because of the d_external
> stuff, but I took a swing at it.  After that, the other commit was a
> quick cherry-pick.
> 
> Al, does the below look correct for a backport on top of 3.17.6?  It
> builds, but I haven't tested it yet.

-       WARN_ON(!hlist_unhashed(&dentry->d_alias));
+       WARN_ON(!hlist_unhashed(&dentry->d_u.d_alias));
i

in __d_free() is definitely *not* correct - where do you think has __d_free
address come from?  Right, dentry->d_u.d_rcu.func...  Those checks belong
in dentry_free(), before call_rcu() is called...
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/