linux-kernel - Re: [PATCH v10] iopoll: Introduce memory-mapped IO polling macros

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141216094527.GC6580@arm.com>
Date:	Tue, 16 Dec 2014 09:45:27 +0000
From:	Will Deacon <will.deacon@....com>
To:	Mitchel Humpherys <mitchelh@...eaurora.org>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"iommu@...ts.linux-foundation.org" <iommu@...ts.linux-foundation.org>,
	Thierry Reding <thierry.reding@...il.com>,
	Arnd Bergmann <arnd@...db.de>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Robert Elliott <elliott@...com>,
	Matt Wagantall <mattw@...eaurora.org>
Subject: Re: [PATCH v10] iopoll: Introduce memory-mapped IO polling macros

On Mon, Dec 15, 2014 at 11:47:23PM +0000, Mitchel Humpherys wrote:
> From: Matt Wagantall <mattw@...eaurora.org>
> 
> It is sometimes necessary to poll a memory-mapped register until its value
> satisfies some condition. Introduce a family of convenience macros that do
> this. Tight-looping, sleeping, and timing out can all be accomplished using
> these macros.
> 
> Cc: Thierry Reding <thierry.reding@...il.com>
> Cc: Will Deacon <will.deacon@....com>
> Cc: Arnd Bergmann <arnd@...db.de>
> Cc: Andrew Morton <akpm@...ux-foundation.org>
> Cc: Robert Elliott <elliott@...com>
> Signed-off-by: Matt Wagantall <mattw@...eaurora.org>
> Signed-off-by: Mitchel Humpherys <mitchelh@...eaurora.org>
> ---
> v9..10:
>   - Actually added the comments mentioned in v8..v9 (doh!)
> 
> v8..v9:
>   - Added note in comments about max sleep time (Rob Elliott)
> 
> v7..v8:
>   - sorted helper macros by size (b, w, l, q)
>   - removed some of the more esoteric (or flat-out bogus) helper macros
> 
> This patch was originally part of a series [1] for adding support for IOMMU
> address translations through an ARM SMMU hardware register.  The other
> patch in the series (the one that actually uses these macros and implements
> said hardware address translations) was Ack'd by the driver maintainer
> there (Will Deacon) so I've pulled this patch out to avoid resending an
> already Ack'd patch over and over again.
> 
> In short, please see [1] for previous discussion and the first user of
> these macros.
> 
> Will also acked this patch in [2].  I didn't retain his Ack here because I
> added to the macro comments.

You can keep the ack, it still looks good to me and I'm not really fussed
about the comments.

Will
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/