linux-kernel - Re: linux-next: build failure after merge of the infiniband tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <54901021.9020205@mellanox.com>
Date:	Tue, 16 Dec 2014 12:57:37 +0200
From:	Or Gerlitz <ogerlitz@...lanox.com>
To:	Roland Dreier <roland@...nel.org>,
	Stephen Rothwell <sfr@...b.auug.org.au>
CC:	"linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
	Haggai Eran <haggaie@...lanox.com>,
	"linux-next@...r.kernel.org" <linux-next@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Yevgeny Petrilin <yevgenyp@...lanox.com>,
	Amir Vadai <amirv@...lanox.com>
Subject: Re: linux-next: build failure after merge of the infiniband tree

On 12/16/2014 3:56 AM, Roland Dreier wrote:
> On Mon, Dec 15, 2014 at 5:47 PM, Stephen Rothwell <sfr@...b.auug.org.au> wrote:
>> Hi all,
>>
>> After merging the infiniband tree, today's linux-next build (x86_64
>> allmodconfig) failed like this:
>>
>> drivers/infiniband/hw/mlx5/main.c: In function 'mlx5_ib_query_device':
>> drivers/infiniband/hw/mlx5/main.c:248:34: error: 'MLX5_DEV_CAP_FLAG_ON_DMND_PG' undeclared (first use in this function)
>>    if (dev->mdev->caps.gen.flags & MLX5_DEV_CAP_FLAG_ON_DMND_PG)
>>                                    ^
>> [...]
>> Really?  Code added half way though the merge window not even build
>> tested?
> It's not quite as bad as it seems.  The infiniband tree itself builds,
> the problem is the merged tree.
>
> The Mellanox guys merged the "cleanup"

Hi Roland,

So shit happens... Eli is away this week, but it's clear that this 
portion of the cleanup
was terribly wrongand done by mistake, sorry for that and thanks for 
addressing quickly.

Or.

>
> commit 0c7aac854f52
> Author: Eli Cohen <eli@....mellanox.co.il>
> Date:   Tue Dec 2 02:26:14 2014
>
>      net/mlx5_core: Remove unused dev cap enum fields
>
>      These enumerations are not used so remove them.
>
>      Signed-off-by: Eli Cohen <eli@...lanox.com>
>      Signed-off-by: David S. Miller <davem@...emloft.net>
>
> through davem's tree, and then went ahead and used at least
> MLX5_DEV_CAP_FLAG_ON_DMND_PG (which that patch removes) in patches
> they merged through my tree.
>
> I'll add a partial revert of that patch to my tree to get back the
> now-used enum values.
>
>   - R.
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/