linux-kernel - Re: [PATCH] drivers: staging: lustre: Use mult if units not specified

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 16 Dec 2014 14:35:09 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	"Dilger, Andreas" <andreas.dilger@...el.com>
Cc:	Chris Rorvick <chris@...vick.com>,
	"devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
	Fabian Frederick <fabf@...net.be>,
	Julia Lawall <Julia.Lawall@...6.fr>,
	Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>,
	James Simmons <uja.ornl@...il.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"Drokin, Oleg" <oleg.drokin@...el.com>,
	Greg Donald <gdonald@...il.com>,
	Andriy Skulysh <Andriy_Skulysh@...atex.com>,
	"HPDD-discuss@...1.01.org" <HPDD-discuss@...1.01.org>,
	"Hammond, John" <john.hammond@...el.com>
Subject: Re: [PATCH] drivers: staging: lustre: Use mult if units not specified

On Tue, Dec 16, 2014 at 11:14:35AM +0000, Dilger, Andreas wrote:
>
> Sorry, that isn't right.  Chris' patch is actually doing the right thing
> to check for units > 1.

It's not right because it discards the negative.

>  The proposed change above discards "mult"
> entirely, which breaks the users of this function that are not in this
> file (e.g. osc_cached_mb_seq_write() or ll_max_cached_mb_seq_write())
> that have tunables in units of MB by default, but can also use parameters
> with units like "4.5G" for convenience.

I think you are confusing lprocfs_write_frac_helper() and
lprocfs_write_frac_u64_helper().  There is only one caller for this
function.

! grep lprocfs_write_frac_u64_helper drivers/staging/lustre/ -R | grep -v smatch  | grep -v '\.i:'
drivers/staging/lustre/lustre/obdclass/lprocfs_status.c:        return lprocfs_write_frac_u64_helper(buffer, count, val, 1);
drivers/staging/lustre/lustre/obdclass/lprocfs_status.c:int lprocfs_write_frac_u64_helper(const char *buffer, unsigned long count,
drivers/staging/lustre/lustre/obdclass/lprocfs_status.c:EXPORT_SYMBOL(lprocfs_write_frac_u64_helper);
drivers/staging/lustre/lustre/include/lprocfs_status.h:extern int lprocfs_write_frac_u64_helper(const char *buffer,

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/