linux-kernel - Re: [PATCH] staging: rtl8723au: core: fixing "foo * bar" should be "foo *bar"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 16 Dec 2014 07:43:34 -0500
From:	Jes Sorensen <Jes.Sorensen@...hat.com>
To:	Asaf Vertz <asaf.vertz@...demg.com>
Cc:	Larry.Finger@...inger.net, gregkh@...uxfoundation.org,
	ninox@...teo.net, tapaswenipathak@...il.com, gdonald@...il.com,
	cmroliv@...il.com, linux-wireless@...r.kernel.org,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: rtl8723au: core: fixing "foo * bar" should be "foo *bar"

Asaf Vertz <asaf.vertz@...demg.com> writes:
> Fixed a coding style error, "foo * bar" should be "foo *bar"
>
> Signed-off-by: Asaf Vertz <asaf.vertz@...demg.com>
> ---
>  drivers/staging/rtl8723au/core/rtw_efuse.c |   12 ++++++------
>  1 files changed, 6 insertions(+), 6 deletions(-)

If you want to fix the 'error' here, include it with a cleanup that also
fixes the ugly multiline arguments to the functions.

Jes

> diff --git a/drivers/staging/rtl8723au/core/rtw_efuse.c b/drivers/staging/rtl8723au/core/rtw_efuse.c
> index 81960e7..0e64d12 100644
> --- a/drivers/staging/rtl8723au/core/rtw_efuse.c
> +++ b/drivers/staging/rtl8723au/core/rtw_efuse.c
> @@ -328,12 +328,12 @@ EFUSE_Read1Byte23a(struct rtw_adapter *Adapter, u16 Address)
>  
>  void
>  EFUSE_Write1Byte(
> -	struct rtw_adapter *	Adapter,
> +	struct rtw_adapter *Adapter,
>  	u16		Address,
>  	u8		Value);
>  void
>  EFUSE_Write1Byte(
> -	struct rtw_adapter *	Adapter,
> +	struct rtw_adapter *Adapter,
>  	u16		Address,
>  	u8		Value)
>  {
> @@ -636,7 +636,7 @@ Efuse_ReadAllMap(struct rtw_adapter *pAdapter, u8 efuseType, u8 *Efuse)
>   *---------------------------------------------------------------------------*/
>  static void
>  efuse_ShadowRead1Byte(
> -	struct rtw_adapter *	pAdapter,
> +	struct rtw_adapter *pAdapter,
>  	u16		Offset,
>  	u8		*Value)
>  {
> @@ -648,7 +648,7 @@ efuse_ShadowRead1Byte(
>  /* Read Two Bytes */
>  static void
>  efuse_ShadowRead2Byte(
> -	struct rtw_adapter *	pAdapter,
> +	struct rtw_adapter *pAdapter,
>  	u16		Offset,
>  	u16		*Value)
>  {
> @@ -661,7 +661,7 @@ efuse_ShadowRead2Byte(
>  /* Read Four Bytes */
>  static void
>  efuse_ShadowRead4Byte(
> -	struct rtw_adapter *	pAdapter,
> +	struct rtw_adapter *pAdapter,
>  	u16		Offset,
>  	u32		*Value)
>  {
> @@ -723,7 +723,7 @@ void EFUSE_ShadowMapUpdate23a(struct rtw_adapter *pAdapter, u8 efuseType)
>   *---------------------------------------------------------------------------*/
>  void
>  EFUSE_ShadowRead23a(
> -	struct rtw_adapter *	pAdapter,
> +	struct rtw_adapter *pAdapter,
>  	u8		Type,
>  	u16		Offset,
>  	u32		*Value)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/